Showing error 1354

User: Jiri Slaby
Error type: Leaving function in locked state
Error type description: Some lock is not unlocked on all paths of a function, so it is leaked
File location: fs/nfs/client.c
Line in file: 1446
Project: Linux Kernel
Project version: 2.6.28
Tools: Stanse (1.2)
Entered: 2012-05-21 20:30:05 UTC


Source:

1416                   clp->cl_hostname);
1417
1418        return 0;
1419}
1420
1421/*
1422 * open "/proc/fs/nfsfs/volumes" which provides a summary of extant volumes
1423 */
1424static int nfs_volume_list_open(struct inode *inode, struct file *file)
1425{
1426        struct seq_file *m;
1427        int ret;
1428
1429        ret = seq_open(file, &nfs_volume_list_ops);
1430        if (ret < 0)
1431                return ret;
1432
1433        m = file->private_data;
1434        m->private = PDE(inode)->data;
1435
1436        return 0;
1437}
1438
1439/*
1440 * set up the iterator to start reading from the volume list and return the first item
1441 */
1442static void *nfs_volume_list_start(struct seq_file *m, loff_t *_pos)
1443{
1444        /* lock the list against modification */
1445        spin_lock(&nfs_client_lock);
1446        return seq_list_start_head(&nfs_volume_list, *_pos);
1447}
1448
1449/*
1450 * move to next volume
1451 */
1452static void *nfs_volume_list_next(struct seq_file *p, void *v, loff_t *pos)
1453{
1454        return seq_list_next(v, &nfs_volume_list, pos);
1455}
1456
Show full sources